88241: cdc: fix assignment to nil map panic in json encoder r=[miretskiy] a=HonoreDB JSON encoding a delete message for a deleted row was panicking. This fixes that. Release note (bug fix): Fixed a crash in changefeed expressions when JSON encoding an empty projection. 88272: cli/sql: delay writing the history file to the end r=DrewKimball a=knz Fixes #54679. Previously, the shell would write to the history file in-between each input. This was incurring noticeable delays if the history file was large. This patch fixes that by delaying the file write until the end. This is akin to the behavior of unix shell. There is no user-visible change except in the case of a crash of the shell itself, which at this point has become extremely rare. Release note: None 88275: upgrade/upgrades: make schema telemetry migration idempotent r=ajwerner a=ajwerner Fixes #88273 Release note: None 88279: admission: squash data race in accessing token bucket r=irfansharif a=irfansharif Fixes #88269, fallout from #88031 -- sloppy assumption that the token bucket type is thread-safe. Instantly reproduced using: dev test pkg/ccl/changefeedccl \ -f=TestAlterChangefeedAddTarget/cloudstorage \ --race --stress --timeout 1m Release note: None Release justification: Fixes data race in non-production code 88300: stats: make recent fix more conservative r=yuzefovich a=yuzefovich We recently merged a fix for histograms of INT2 and INT4 types to not exceed their range, and we used an exact equality against the boundary values when determining whether "outer" buckets are needed. This commit makes that logic more bullet-proof by using an inequality. The sampled values that exceed the supported ranges for the types should not really happen, but let's be conservative. Release note: None Co-authored-by: Aaron Zinger <zinger@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net> Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>

upgrades: schema telemetry upgrade is not idempotent #88273

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions