95679: sql: remove extra type hint from `SHOW CREATE VIEW` r=rafiss a=e-mbrown Resolves: #87886 Views created with user provided type hints were given extra type annotations. The format functions for `AnnotateTypeExpr` and `Array` were both annotating the expression. This commit alters the format function of `AnnotateTypeExpr` so it doesnt duplicate annotations for arrays. Release note: None 95703: obsservice: support embedding in CRDB nodes r=andreimatei a=andreimatei This patch adds a special value to the --obsservice-addr CRDB flag: --obsservice-addr=embed means that an the respective node will run the Obs Service RPC service internally and the events exporter will be configured to connect to this internal service. Release note: None Fixes #88194 Epic: CRDB-16791 97410: storage: write min version file with checkpoint r=RaduBerinde a=RaduBerinde #### storage: better error for missing min version file We require the min version filename to open a store. If it doesn't exist, we assume the store doesn't exist which can lead to a confusing message if just the min version file is missing. This commit makes this message more useful. Informs #97337 Release note: none Epic: none #### storage: write min version file with checkpoint We now write out the min version file with checkpoints generated through the storage layer. This allows checkpoints to be opened with the cockroach storage layer (not just with the low level pebble tool). Fixes #97337 Release note: None Epic: none 97433: cli: remove double quotes from a test file name r=yuzefovich a=yuzefovich This commit removes double quotes from a recently introduced test file since apparently windows doesn't like them which [breaks](https://github.com/cockroachdb/cockroach/actions/runs/4236059742) the bincheck run. Epic: None Release note: None Co-authored-by: e-mbrown <ebsonari@gmail.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>

obsservice: embed in CRDB #88194

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions