-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql, stable ids for roles: complete remaining role id migrations in system tables #87079
Copy link
Copy link
Closed
Closed
Copy link
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Description
Role Ids were added to system.users in #81457.
In 22.2, once the migration is done and we're on V22_2SystemUsersIDColumnIsBackfilled version, we're guaranteed every user has an ID. Furthermore, in 23.1, we're guaranteed that all users have ids.
Eventually, we want to start using IDs to refer to users (ie for privilege checks) instead of usernames and support operations such as alter role rename.
We still have to migrate the following tables:
-
system.role_members -
system.privileges -
system.database_role_settings -
system.web_sessions -
system.external_connections
The system.role_members migration is PR is out #85928 and will wait for the 22.2 branch cut before merging.
The migrations should look like the migration done in #85845
Jira issue: CRDB-19140
Epic CRDB-19134
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)