-
Notifications
You must be signed in to change notification settings - Fork 4.1k
backupccl: write table stats in order in backup metadata sst #86806
Copy link
Copy link
Closed
Labels
A-disaster-recoveryC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-disaster-recovery
Description
#86078 caused the BackupMetadataSST writer to write out of order kvs related to table stats, causing the pebble writer to error, as seen in #86289. One working theory for why this occurs:
Backup currently pulls the stats out of the stats cache and then constructs keys to write into the SST. After #86078, the cache now returns stats per-column stats; however, the keys backup generates look like they are just based on the table id and the stats id. Now, perhaps each key is no longer unique when you put the per-columns stat forecasts in the mix.
Jira issue: CRDB-18943
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-disaster-recoveryC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-disaster-recovery