-
Notifications
You must be signed in to change notification settings - Fork 4.1k
storage: MVCCGet showing significant MVCCIterator.Stats() CPU time #86083
Copy link
Copy link
Closed
Labels
A-storageRelating to our storage engine (Pebble) on-disk storage.Relating to our storage engine (Pebble) on-disk storage.C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.T-storageStorage TeamStorage Team
Description
MVCCIterator.Stats() has been seen to use ~4% of CPU during MVCCGet benchmarks:
This is used to attach iterator stats to a running trace, but the stats collection is called unconditionally (regardless of whether an actual trace is in progress):
Lines 999 to 1000 in 9fb8d36
| // If we have a trace, emit the scan stats that we produced. | |
| recordIteratorStats(ctx, mvccScanner.stats()) |
Jira issue: CRDB-18562
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-storageRelating to our storage engine (Pebble) on-disk storage.Relating to our storage engine (Pebble) on-disk storage.C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.T-storageStorage TeamStorage Team
