-
Notifications
You must be signed in to change notification settings - Fork 4.1k
serverccl: package times out during shutdown causing flakes #85944
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.C-test-failureBroken test (automatically or manually discovered).Broken test (automatically or manually discovered).branch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.
Description
Describe the problem
The serverccl package has been timing out.
One theory:
Seems like the server fails to shut down because we’re waiting for quiescence but the contexts are not getting canceled correctly or something and we’re in an infinite retry inside
kv/kvclient/rangecache.(*RangeCache).tryLookup.
Using a bisect I landed on 262a70d as the first bad commit, but I don't see why.
To Reproduce
The TestNoInflightTracesVirtualTableOnTenant test reproes it.
./dev test pkg/ccl/serverccl --stress --filter=TestNoInflightTracesVirtualTableOnTenant --timeout=2m --test-args='-test.timeout 20s'
Jira issue: CRDB-18494
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.C-test-failureBroken test (automatically or manually discovered).Broken test (automatically or manually discovered).branch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.