-
Notifications
You must be signed in to change notification settings - Fork 4.1k
scop: audit operation names #84583
Copy link
Copy link
Closed
Labels
A-schema-changer-implRelated to the implementation of the new schema changerRelated to the implementation of the new schema changerC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-easyEasy issue to tackle, requires little or no CockroachDB experienceEasy issue to tackle, requires little or no CockroachDB experienceGA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.
Description
Declarative schema changer operation names and their field names are mildly inconsistent. For instance we have a pattern where index state changing ops are named MakeBackfilledIndexMerging, MakeBackfillingIndexDeleteOnly, etc. but we also have MakeAddedIndexDeleteAndWriteOnly which doesn't conform to the pattern. As far as fields are concerned we have a mix of DescID, DescriptorID etc.
None of this matters in any other way than: this stuff shows up in EXPLAIN (DDL) output. Let's make it consistent in time for this release. It shouldn't be hard or take long, but will result in noisy test changes.
Jira issue: CRDB-17746
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-schema-changer-implRelated to the implementation of the new schema changerRelated to the implementation of the new schema changerC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-easyEasy issue to tackle, requires little or no CockroachDB experienceEasy issue to tackle, requires little or no CockroachDB experienceGA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.