-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvserver: migrate multiTestContext to TestCluster #8299
Copy link
Copy link
Labels
A-kv-replicationRelating to Raft, consensus, and coordination.Relating to Raft, consensus, and coordination.A-kv-serverRelating to the KV-level RPC serverRelating to the KV-level RPC serverA-testingTesting tools and infrastructureTesting tools and infrastructureC-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Description
multiTestContext runs multiple Stores without Servers, and to do so it has to mock out the transport layer. Originally this was done because it was not feasible to use the regular Gossip and DistSender in this environment, but now we've moved closer to the standard environment and the last piece missing is the Server. We should go the rest of the way and move these tests to TestCluster, adding features to TestCluster as needed.
The immediate motivation for this change is deadlocks that result from multiTestContext using one RWMutex for too many things: #8170 and #7678.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-replicationRelating to Raft, consensus, and coordination.Relating to Raft, consensus, and coordination.A-kv-serverRelating to the KV-level RPC serverRelating to the KV-level RPC serverA-testingTesting tools and infrastructureTesting tools and infrastructureC-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.