Skip to content

storage: remove inline value support from MVCCIncrementalIterator #82507

@erikgrinaker

Description

@erikgrinaker

MVCCIncrementalIterator currently allows returning inline values via MVCCIncrementalIterInlinePolicyEmit. However, this is not safe to combine with time-bound iterators, which will become enabled by default in #82453 -- these will omit inline values since they do not fall within the time bounds. It is not clear that inline values even make sense for this iterator, since a) they're not MVCC; and b) they don't have timestamps, so we should remove support for them and error if encountered.

The only caller that enables inline values is rangefeeds. It's not clear that they make sense there either. See #69357.

Jira issue: CRDB-16491

Metadata

Metadata

Assignees

Labels

A-kv-replicationRelating to Raft, consensus, and coordination.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions