-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvstreamer: improve the stability #82160
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-queriesSQL Queries TeamSQL Queries Teamsync-me
Description
Currently, the usage of the streamer library seems to make things less stable memory-wise than before - which goes against the goal of the library. We should achieve higher number in tpch_concurrency roachtest with the streamer enabled. I think the root cause is that the streamer creates many more objects in general (increasing pressure on the GC), and large slices are not accounted for yet.
We should:
- remove allocations as much as possible
- make sure all things are accounted for
consider makingResultan interface so that depending onHintsandModewe could have smaller-size implementations.
Jira issue: CRDB-16320
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-queriesSQL Queries TeamSQL Queries Teamsync-me
Type
Projects
Status
Done