kvserver: pebble panic from WriteSyncNoop #81827
Description
Describe the problem
In a recent CI failure a number of TestExecBuild tests failed to return results; however the root cause seems to be a panic from the liveness system:
panic: pebble: closed
goroutine 97893 [running]:
github.com/cockroachdb/pebble.(*DB).Apply(0x0, 0x56fb700, 0xc006fa6000)
github.com/cockroachdb/pebble/external/com_github_cockroachdb_pebble/db.go:717 +0x3c9
github.com/cockroachdb/pebble.(*Batch).Commit(...)
github.com/cockroachdb/pebble/external/com_github_cockroachdb_pebble/batch.go:932
github.com/cockroachdb/cockroach/pkg/storage.(*pebbleBatch).Commit(0xc01a0959e0, 0x0)
github.com/cockroachdb/cockroach/pkg/storage/pebble_batch.go:495 +0x3c
github.com/cockroachdb/cockroach/pkg/storage.WriteSyncNoop({0x57cd8f8, 0xc01a0959e0})
github.com/cockroachdb/cockroach/pkg/storage/engine.go:938 +0xba
github.com/cockroachdb/cockroach/pkg/kv/kvserver/liveness.(*NodeLiveness).updateLiveness.func1()
github.com/cockroachdb/cockroach/pkg/kv/kvserver/liveness/liveness.go:1274 +0x25
github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight.(*Group).doCall(0xc0291f7890, 0xc02ef44a50, {0x42b9a51, 0x1}, 0xc033470bd0)
github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight/singleflight.go:128 +0x3b
created by github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight.(*Group).DoChan
github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight/singleflight.go:121 +0x2f1
I220525 12:35:49.000498 1 (gostd) testmain.go:78 [-] 1 Test //pkg/sql/opt/exec/execbuilder:execbuilder_test exited with error code 2
Jira issue: CRDB-16097