-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql/schemachanger: properly validate NOT NULL columns #81690
Copy link
Copy link
Closed
Labels
A-schema-changer-implRelated to the implementation of the new schema changerRelated to the implementation of the new schema changerC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Description
Describe the problem
At time of writing, the declarative schema changer does not validate the NOT NULL nature of newly added columns. The change in #81679 captures most of what is necessary: push the logic into the index backfiller. The remaining case that needs to be covered is validating the NOT NULL nature of virtual computed columns, which is being handled separately for the legacy schema changer.
Jira issue: CRDB-16031
Epic CRDB-43310
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-schema-changer-implRelated to the implementation of the new schema changerRelated to the implementation of the new schema changerC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)