json: AsText method unnecessarily returns pointer to string and error #81097
Description
Noticed while working on #80000: the method AsText() in json.JSON returns (*string, error).
I think it's silly?
- none of the methods actually return an error. It's unnecessary to pay the price of a 2nd error return.
- all of the methods create a
stringand then allocate (on the heap) a reference to it. Why not returning thestringdirectly?
Also, why not use the (edit: nvm).String() method directly, which seems to do the same?
cc @yuzefovich
Jira issue: CRDB-15147