sql/schemachanger: remove regional-by-row fallback from add column in declarative schema changer #80545
Description
The declarative schema changer is currently disabled when adding columns in the following scenarios:
- Legacy schema changer will be used whenever serial and generated columns are observed.
- Regional by row tables will default to the legacy schema changer since we are missing proper support for updating zone configs
- Columns with the unique constraint will default to the legacy schema changer
- Expressions using sequences will default to the legacy schema changer (DEFAULT, ON UPDATE, COMPUTED) (see sql: use declarative schemachange for add column sequence exprs #81782)
- Better errors can be surfaced on backfill errors for the declarative schema changer. At least one case falls to the legacy one today for this purpose (already fixed in the original PR)
-
Tests which need the MVCC backfiller are currently using the legacy schema changer -
REFERENCESforeign key constraints
Jira issue: CRDB-15351
Epic CRDB-31282
Metadata
Metadata
Assignees
Labels
Related to the implementation of the new schema changerSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docsIssues/test failures with a fix SLA of 3 monthsSQL Foundations Team (formerly SQL Schema + SQL Sessions)