-
Notifications
You must be signed in to change notification settings - Fork 4.1k
admission control: implementation of the sqlNodeCPUOverloadIndicator for single-tenant SQL nodes #79425
Copy link
Copy link
Open
Labels
A-admission-controlA-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-admission-controlAdmission ControlAdmission Control
Description
This is a separate issue for the third item in #65954.
sqlNodeCPUOverloadIndicator is the implementation of the cpuOverloadIndicator interface for a single-tenant SQL node in a multi-tenant cluster. This has to rely on the periodic load information from the cpu scheduler and will therefore be tuned towards indicating overload at higher overload points (otherwise we could fluctuate into underloaded territory due to restricting admission, and not be work conserving). Such tuning towards more overload, and therefore more queueing inside the scheduler, is somewhat acceptable since a SQL node is not multi-tenant.
This issue covers the work to implement it, since isOverloaded() currently just returns false.
Epic CRDB-13762
Jira issue: CRDB-14838
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-admission-controlA-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-admission-controlAdmission ControlAdmission Control