release: 22.1 microbenchmark regression investigation and sign-off #78592
Description
This is a tracking bug for issues we want to investigate related to performance for 21.2 similar to what's been done for prior releases (#71820).
SQL
pkg/sql/...
benchdiff --new==574b6ac --old=89530d8 --count=10 --post-checkout='make buildshort' --sheets ./pkg/sql...
pkg/bench
benchdiff --new=d54f5b78be --old=e179238221 --count=10 --post-checkout='make buildshort' --sheets ./pkg/bench
NOTE: BenchmarkSQL//InsertFK has been skipped since it occasionally gets stuck on the old sha.
pkg/col...
benchdiff --new=e179238 --old=d54f5b7 --count=10 --post-checkout='make buildshort' --sheets ./pkg/col...
KV
./pkg/gossip/...
./pkg/roachpb
./pkg/rpc/...
./pkg/server/...
benchdiff --new=99972ef --old=1831ab7 --count=10 --post-checkout='make buildshort' --sheets ./pkg/kv/kvserver/concurrency ./pkg/kv/kvserver/gc ./pkg/kv/kvserver/raftentry ./pkg/kv/kvserver/rangefeed ./pkg/kv/kvserver/spanlatch ./pkg/kv/kvserver/tscache
Bulk I/O
benchdiff --new=99972ef --old=1831ab7 --count=10 --post-checkout='make buildshort' --sheets ./pkg/blobs
NOTE: results are empty because the benches don't suppress stdout causing results to be on subsequent lines
Storage
pkg/ccl/storageccl/...
benchdiff --new=99972ef --old=1831ab7 --count=10 --post-checkout='make buildshort' --sheets ./pkg/ccl/storageccl/...
Misc
./pkg/base ./pkg/ccl/utilccl/... ./pkg/ccl/workloadccl/... ./pkg/cli/... ./pkg/clusterversion ./pkg/cmd/... ./pkg/internal/... ./pkg/security ./pkg/settings ./pkg/testutils/... ./pkg/ts/... ./pkg/util/... ./pkg/workload/...
benchdiff --new=99972ef --old=1831ab7 --count=10 --post-checkout='make buildshort' --sheets ./pkg/base ./pkg/ccl/utilccl/... ./pkg/ccl/workloadccl/... ./pkg/cli/... ./pkg/clusterversion ./pkg/cmd/... ./pkg/internal/... ./pkg/security ./pkg/settings ./pkg/testutils/... ./pkg/ts/... ./pkg/workload/...
NOTE: pkg/util had to be skipped because it failed to build in the old version,
building benchmark binaries for '1831ab7' 160/257 |
fatal: building test binary: exit status 2: # github.com/cockroachdb/cockroach/pkg/util/goschedstats.test
go.info.runtime.sched: relocation target go.info.github.com/cockroachdb/cockroach/pkg/util/goschedstats.schedt not defined
go.info.runtime.allp: relocation target go.info.[]*github.com/cockroachdb/cockroach/pkg/util/goschedstats.p not defined
Issues:
- Missing many benchmarks including /pkg/blobs; see comment below
- Append/bytes and Copy/bytes regression is a deliberate tradeoff for coldata: change Bytes vector implementation #76202
- Phases/many-columns-and-indexes regression is a deliberate tradeoff for util: support 128 FastIntSet elements without allocation #72798
- Fixed crash in 21.2 branch of pkg/col/colserde
- Rerun pkg/bench after skipping BenchmarkSQL/InsertFK which occasionally get stuck
- Rerun pkg/sql after fixing some of the benchmark issues on the 22.1 branch
- Huge regressions on regression aggregates are a deliberate tradeoff in favor of correctness in builtins: used Decimals to calculate transition values for aggregate function #74372
Jira issue: CRDB-14191