-
Notifications
You must be signed in to change notification settings - Fork 4.1k
bazel: dev generate requires npm and yarn, even though it doesn't need to #76521
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-build-systemB-os-bsdIssues specific to a BSD OS (non-macOS)Issues specific to a BSD OS (non-macOS)C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-dev-inf
Description
Describe the problem
Discussed here: dev generate runs bazel query kind(go_proto_library, //pkg/...) which in turn chokes on #74208.
But there's no reason for bazel query to need that. As @rickystewart explains:
recursing into pkg/ui as part of the bazel query will cause Bazel to try to pull UI bits from NPM. In generate-test-suites we explicitly exclude ui and genbzl should probably be changed to do the same
Epic CRDB-8036
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-build-systemB-os-bsdIssues specific to a BSD OS (non-macOS)Issues specific to a BSD OS (non-macOS)C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-dev-inf