-
Notifications
You must be signed in to change notification settings - Fork 4.1k
testserver: rename GetHTTPClient to GetUnauthenticatedHTTPClient #76241
Copy link
Copy link
Closed
Labels
A-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experienceEasy issue to tackle, requires little or no CockroachDB experienceE-starterMight be suitable for a starter project for new employees or team members.Might be suitable for a starter project for new employees or team members.T-server-and-securityDB Server & SecurityDB Server & Securitygood first issue
Description
Suggested by @dhartunian
the problem to solve is that it's currently just too easy to create a test for a HTTP API without authentication, which does not invite the implementer to care about authn (nor authorization).
We can nudge this in the right direction by renaming the "simple" method to a longer name with a discouragement in the comment; then renaming the admin method to a "simple" name so that it's easier to find.
Jira issue: CRDB-13044
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experienceEasy issue to tackle, requires little or no CockroachDB experienceE-starterMight be suitable for a starter project for new employees or team members.Might be suitable for a starter project for new employees or team members.T-server-and-securityDB Server & SecurityDB Server & Securitygood first issue