-
Notifications
You must be signed in to change notification settings - Fork 4.1k
build: Source archive doesn't include JS bundles for Db Console #75137
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.no-issue-activity
Description
Describe the problem
The way JS assets embedded into GO binaries was changed from using go-bindata to //go:embed directive and this change requires to copy JS bundled files (from pkg/ui/dist{ccl|oss}) into archive to make sure that:
- user doesn't need to build JS assets from sources
- JS assets are available during build to be embedded into GO binaries
To Reproduce
- run
make build && make archive - unzip archive generated with step 1 and
cdinto archive - run
make buildfrom within archive - run cluster
./cockroach start-single-node --insecure - open Db Console in web browser
- and Db Console assets aren't loaded (
bundle.js,vendor.dll.js, andprotos.dll.js)
Expected behavior
Assets loaded and Db Console page is rendered
Environment:
- CockroachDB version 22.1
Additional context
What was the impact?
- It is regression issue. Before, JS assets were embedded with
go-bindataand then it was switched to use //go:embed directive. It affectedmake archivetarget. (07e97b6)
Jira issue: CRDB-12482
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.no-issue-activity
