-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvprober: write structured logs #74405
Copy link
Copy link
Closed
Labels
A-kv-observabilityC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)O-sreFor issues SRE opened or otherwise cares about tracking.For issues SRE opened or otherwise cares about tracking.X-staleno-issue-activity
Description
Is your feature request related to a problem? Please describe.
Today, the kvprober logs are text-based. These are hard to parse programatically. This makes it hard to analyze the logs programmatically, and also write alerts (we have time-series metrics for alerting but for single range issue a log-based alert may be the move).
Describe the solution you'd like
We could do structured logging via pkg/util/log/eventpb.
Describe alternatives you've considered
Only alternative I can think of is not doing anything.
Additional context
N/A
Jira issue: CRDB-12067
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-observabilityC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)O-sreFor issues SRE opened or otherwise cares about tracking.For issues SRE opened or otherwise cares about tracking.X-staleno-issue-activity