-
Notifications
You must be signed in to change notification settings - Fork 4.1k
log: the 21.2 refactor removed auto-redaction for log tags #72905
Copy link
Copy link
Closed
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.regressionRegression from a release.Regression from a release.
Description
Describe the problem
In 21.1 and prior versions, the "tags" part of a log entry envelope were redacted if the sink flag redact was set to true.
In 21.2, this redaction is not taking place any more. This is a regression.
To Reproduce
cockroach start-single-node ... --log='sinks: {stderr: {filter: INFO, redact: true}}'
Expected behavior
redactable value are redacted
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.regressionRegression from a release.Regression from a release.