Skip to content

storage: optimize UpdateSSTTimestamps() #72528

@erikgrinaker

Description

@erikgrinaker

In #72085, we added storage.UpdateSSTTimestamps() which is used to rewrite ingested SST MVCC timestamps to the request timestamp in order to comply with the timestamp cache and closed timestamp. However, this is a very slow implementation, which needs optimization.

This optimization should probably be done in Pebble, to take advantage of its internal data structures. For example, the rewrite could process blocks in parallel, and simply copy the Bloom filters and value checksums without recomputation as these do not depend on the MVCC timestamp.

Epic CRDB-2624

Metadata

Metadata

Assignees

Labels

A-storageRelating to our storage engine (Pebble) on-disk storage.C-performancePerf of queries or internals. Solution not expected to change functional behavior.T-disaster-recovery

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions