-
Notifications
You must be signed in to change notification settings - Fork 4.1k
log: indicate which sink is the cause of an error when a logging error is reporte #72461
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-error-handlingError messages, error propagations/annotationsError messages, error propagations/annotationsA-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Description
This is follow up work to #70330.
Currently in log/flags.go we see the following:
errCallback ≔ λ(err error) {
// TODO(knz): explain which sink is encountering the error in the
// error message.
Ops.Errorf(context.Background(), "logging error: %v", err)
}
if s.criticality {
// TODO(knz): explain which sink is encountering the error in the
// error message.
errCallback = λ(err error) {
Ops.Errorf(context.Background(), "logging error: %v", err)
...The logging error message does not include detail about which sink is causing the error, which makes troubleshooting difficult.
We want to annotate some information about the sink in the error report.
Jira issue: CRDB-11169
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-error-handlingError messages, error propagations/annotationsError messages, error propagations/annotationsA-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)