-
Notifications
You must be signed in to change notification settings - Fork 4.1k
log: simplify the buffering count for flusherCh in bufferSink #72460
Copy link
Copy link
Closed
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Description
This is follow up work to #70330.
The current bufferSink flusher uses a manually maintained atomic counter nInFlight to track the number of messages buffered.
This could be advantageously simplified by a native buffered Go channel, with a select on blocked writes to check when the channel is full.
Jira issue: CRDB-11168
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.