-
Notifications
You must be signed in to change notification settings - Fork 4.1k
log: introduce more metrics into log pkg for network logging #72453
Copy link
Copy link
Closed
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)O-sreFor issues SRE opened or otherwise cares about tracking.For issues SRE opened or otherwise cares about tracking.
Description
This is follow up work to #70330.
Since #106607, we now have the ability to add metrics to the log package.
While the original PR adds a metric to track fluentbit connection errors, we should add additional metrics such as:
- When the output buffer becomes full, the new buffer sink implementation chooses to drop messages instead of blocking the log call (this is a feature). Count these.
- Count of log messages flowing through the log package.
- Error counts
- ???
Use the new infra to add useful new metrics to pkg/util/log, with a focus on improving observability around network logging.
Jira issue: CRDB-11161
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)O-sreFor issues SRE opened or otherwise cares about tracking.For issues SRE opened or otherwise cares about tracking.