There are potentially multiple Tooltip components being used in table headers, and I think all of them would benefit from moving the dashed line styling in. Alternatively, changing all of them would be easier if/when the multiple Tooltip components are unified.

These multiple Tooltip components include:

Tooltip from @cockroachlabs/ui-components: https://github.com/cockroachdb/ui/blob/037ff0e7d48d8c101cd5a0d1c2c54c2477d3d36f/packages/ui-components/src/Tooltip/Tooltip.tsx#L35
Direct use of antd tooltip: https://github.com/cockroachdb/cockroach/blob/master/pkg/ui/workspaces/cluster-ui/src/databasesPage/databasesPage.tsx#L13
Tooltip in pkg/ui/workspaces/db-console/src/components/tooltip/tooltip.tsx. This is a wrapper around the antd tooltip: https://github.com/cockroachdb/cockroach/blob/master/pkg/ui/workspaces/db-console/src/components/tooltip/tooltip.tsx
ToolTipWrapper in pkg/ui/workspaces/db-console/src/views/shared/components/toolTip/index.tsx. This is another wrapper around the antd tooltip. Note the different file path from 3, and the two capitalized Ts.

Also, not all Tooltips are table headers, so one would need to de-duplicate the dashed line implementation for those non-table-header Tooltip usages.

And also, @lindseyjin made a temporary UI fix that can be pulled out when this issue is done.

ui: move dashed-underline styling from SortedTable headers to Tooltip #68821

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions