-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Can't use debug merge-logs on logs from 20.2 unless explicitly provide flag #68278
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-server-and-securityDB Server & SecurityDB Server & Security
Description
Describe the problem
When parsing logs from 20.2 format detector will panic unhelpfully. It requires --format crdb-v1 to be passed to proceed which is unfriendly.
To Reproduce
Try
cockroach debug merge-logs with logs
created by cockroach-20.2 and observe
ERROR: decoding format: failed to extract log file format from the log
Expected behavior
We should stick to v1 format if detector fails maybe or provide some helpful message at least?
This change was introduced in #65633
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-server-and-securityDB Server & SecurityDB Server & Security