Skip to content

Can't use debug merge-logs on logs from 20.2 unless explicitly provide flag #68278

@aliher1911

Description

@aliher1911

Describe the problem

When parsing logs from 20.2 format detector will panic unhelpfully. It requires --format crdb-v1 to be passed to proceed which is unfriendly.

To Reproduce

Try

cockroach debug merge-logs with logs 

created by cockroach-20.2 and observe

ERROR: decoding format: failed to extract log file format from the log

Expected behavior
We should stick to v1 format if detector fails maybe or provide some helpful message at least?

This change was introduced in #65633

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-loggingIn and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-server-and-securityDB Server & Security

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions