-
Notifications
You must be signed in to change notification settings - Fork 4.1k
server: audit the direct uses of RPC handler functions from other packages to check for missing authz #67938
Copy link
Copy link
Open
Labels
A-authenticationPertains to authn subsystemsPertains to authn subsystemsA-securityA-server-architectureRelates to the internal APIs and src org for server codeRelates to the internal APIs and src org for server codeC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-server-and-securityDB Server & SecurityDB Server & Security
Description
Identified by @bdarnell in this comment
Today, we have certain places in the code that directly call a Go RPC handler method inside the server package, without actually issuing a RPC call. This bypasses authentication and may thus bypass authorization.
We need to audit these calls to see what to do about them.
In an ideal world:
-
none of the RPC handler methods should be usable from another package. This can be achieved by moving their implementation in a new sub-package
server/internal -
internal logic should be equipped with adequate authorization barriers.
Jira issue: CRDB-8791
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-authenticationPertains to authn subsystemsPertains to authn subsystemsA-securityA-server-architectureRelates to the internal APIs and src org for server codeRelates to the internal APIs and src org for server codeC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-server-and-securityDB Server & SecurityDB Server & Security