67331: sql: store plan as jsonb in system.statement_statistics r=maryliag a=Azhng Previously, we store statement plan as a byte blob column in system.statement_statistics. As of #65782 we now support JSON encoding for the plan. This commit change the column type for plan from BYTES to JSONB in system.statement_statistics. Release note (sql change): using JSONB to store statement plan instead of BYTES in system.statement_statistics. 67340: opt: fix FoldEqZeroSTDistance with use_spheroid argument r=otan a=mgartner The `FoldEqZeroSTDistance` normalization rule normalizes expressions in the form `st_distance(a, b) = 0` to `st_intersects(a, b)`. This normalization rule is important because it allows an inverted index to be used for more queries. Previously, `FoldEqZeroSTDistance` did not handle the third argument of `st_distance` for the geography overload, `use_spheroid`. The optimizer panicked when a user supplied this third argument because it attempted to find an `st_intersects` overload with the three arguments and no such overload exists. In addition to the panic, this rule was incorrectly firing in cases where it shouldn't have. From the [`ST_Distance` PostGIS docs](https://postgis.net/docs/ST_Distance.html): > For geography types defaults to return the minimum geodesic distance > between two geographies in meters, compute on the spheroid determined > by the SRID. If use_spheroid is false, a faster spherical calculation > is used. From the [`ST_Intersects` PostGIS docs](https://postgis.net/docs/ST_Intersects.html): > For geography, this function has a distance tolerance of about 0.00001 > meters and uses the sphere rather than spheroid calculation. In summary, `st_distance` calculates on a spheroid by default, and only on a sphere if `use_spheroid` is explicitly false. `st_intersects` calculates on the sphere always. Therefore, this rule can only apply for geography types if `use_spheroid=false` is explicitly passed. This commit ensures that `FoldEqZeroSTDistance` only matches `st_distance` functions with geography arguments if `use_spheroid=false` is included in the function call. The panic is fixed by stripping the `use_spheroid` argument from the list of arguments used to lookup the `st_intersects` overload. Fixes #67235 Release note (bug fix): Two bugs have been fixed which affected geospatial queries with the `st_distance` function. The first caused errors for filters of the form `st_distance(g1, g2, use_spheroid) = 0`. The second could cause incorrect results in some cases. It incorrectly transformed filters in the form `st_distance(g1, g2) = 0` when `g1` and `g2` are geographies to `st_instersects(g1, g2)`. This is not a valid transformation because `st_distance` makes spheroid-based calculations by default while `st_intersects` only makes sphere-based calculations. 67371: dev: move `dev` back to `cockroach` r=rail a=rickystewart We don't seem to be getting any benefit out of having it in its own repo, and having it in the same repo gives us more flexibility. Closes #67339. Release note: None 67390: roachtest: fix ruby-pg roachtest r=rafiss a=RichardJCai Helper file was moved but path was not updated. Release note: None 67393: roachtest: fix gorm by installing test deps r=RichardJCai a=rafiss fixes #66825 I think this started failing with the move to go1.16. I added these steps to match what gorm does in its own test suite. Release note: None Co-authored-by: Azhng <archer.xn@gmail.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: richardjcai <caioftherichard@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>

dev: move dev back to cockroach repo #67339

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

dev: move `dev` back to `cockroach` repo #67339