-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql: refactor SQL stats colllection to its own self-contained package #65699
Copy link
Copy link
Closed
Labels
A-sql-cli-observabilityIssues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc.Issues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Description
Currently, our SQL statistics code is heavily intertwined with sq.Server, connExecutor and couple other major components. This makes testing and adding new features difficult.
We should create a clear boundary by refactoring stats collection code into its own package and expose well-defined Golang interfaces. This also will pave the way for us to add persisted SQL stats later.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-sql-cli-observabilityIssues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc.Issues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.