-
Notifications
You must be signed in to change notification settings - Fork 4.1k
security: Add version number to base64 form of join tokens #64885
Copy link
Copy link
Closed
Labels
A-authenticationPertains to authn subsystemsPertains to authn subsystemsC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)good first issue
Description
Join tokens are created by the create_join_token() SQL builtin and
returned as base64 encoded strings.
- To account for any future
modifications to the join token format, the marshalled form of it
should have a version number in it at a fixed offset (ideally 0)
in addition to all the existing fields. This will ease in any future
updates to the join token format. - the base64 format can produce strings that start with a hyphen (
-) and this confuses the command-line parser when pasted in argument position on the command line forcockroach connect join.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-authenticationPertains to authn subsystemsPertains to authn subsystemsC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)good first issue