63785: sql: use catalog.Mutation, catalog.Column and catalog.Index where possible r=postamar a=postamar sql: use catalog.Mutation where possible This commit is a refactor which introduces catalog.Mutation wherever possible, in an effort to avoid using the descpb.DescriptorMutation type directly. Release note: None sql: use catalog.Column and catalog.Index where possible This commit is a refactor which introduces the catalog.Column and catalog.Index interfaces wherever possible. These had recently been added in an effort to avoid using the descpb.ColumnDescriptor and descpb.IndexDescriptor types directly. This commit generalizes their usage throughout the sql packages. Fixes #63755. Release note: None 63787: roachtest: added hibernate ignorelist for 21.1 r=rafiss a=mnovelodou Previously, some random issues with hibernate were afecting roachtest This was inadequate because they are false failures To address this, this patch set these tests in ignore list Release note: none 63839: cli: bump the cobra dependency and add autocompletion for fish r=stevendanna a=knz Fixes #63838 . Fixes #50187. This updates the cobra dep which hadn't been updated since 2017. Also picks up the new support for fish autocompletions. Release note (cli change): Certain errors caused by invalid command-line arguments are now printed on the process' standard error stream, instead of standard output. Release note (cli change): The `cockroach gen autocomplete` command has been updated and can now produce autocompletion definitions for the `fish` shell. 63853: build: upgrade go to 1.15.11 r=rail a=rickystewart Pick up fixes to the following Go bugs: * golang/go#45076 * golang/go#45187 * golang/go#42884 * [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [ ] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh#L40-42)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [x] Adjust `GO_VERSION` in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) and ask the Developer Infrastructure team to deploy new images. Resolves #63836. Release note (general change): Upgrade the CRDB binary to Go 1.15.10 63857: changefeedccl: Make `kafka_sink_config` a valid option. r=stevendanna a=miretskiy Add `kafka_sink_config` to the list of allowed changefeed options. Release Notes: None Co-authored-by: Marius Posta <marius@cockroachlabs.com> Co-authored-by: MiguelNovelo <miguel.novelo@digitalonus.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>

sql: use catalog.Column and catalog.Index outside of catalog #63755

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions