-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvserver: assertion leaks batch request to sanitized logs #62765
Copy link
Copy link
Closed
Labels
A-kv-serverRelating to the KV-level RPC serverRelating to the KV-level RPC serverC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.GA-blocker
Description
This new assertion contains the error twice, and one of the copies some inadvertently ends up being considered "safe".
| return nil, makeNonDeterministicFailure("writing at %s below closed ts: %s (%s)", |
F210326 12:02:19.574549 195 kv/kvserver/store_raft.go:524 ⋮ [n9,s9,r9/8:‹×›] 619 writing at 1616760138.160904109,1 below closed ts: 1616760138.508101756,0 (ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/0,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/2/1,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/3/1,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/4/1,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/6/1,/Min), [txn: 36f6bd89]): ‹×›: writing at 1616760138.160904109,1 below closed ts: ‹×› (‹ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/0,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/2/1,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/3/1,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02:14.844713Z/644512934977306627/4/1,/Min), ConditionalPut [/Table/13/1/2021-03-26T12:02
teamcity-2816384-1616738656-21-n10cpu4-0009> F210326 12:02:19.574549 195 kv/kvserver/store_raft.go:524 ⋮ [n9,s9,r9/8:‹×›] 619 |:14.844713Z/644512934977306627/6/1,/Min), [txn: 36f6bd89]›)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-serverRelating to the KV-level RPC serverRelating to the KV-level RPC serverC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.GA-blocker