Skip to content

kvfollowerreadsccl: excessive overhead in canSendToFollower #62447

@erikgrinaker

Description

@erikgrinaker

As seen in #62359, kvfollowerreadsccl.canSendToFollower started using a significant amount of resources in the week before Feb 19. The following flame graph shows that this was via DistSender.sendToReplicas, with the majority of the time spent in pgerror.Newf via checkEnterpriseEnabled.

Screenshot 2021-03-23 at 13 45 06

The offending PR was #59571, kv95 benchmarks show a drop from 60712 ops/s to 55565 ops/s (median over 5 runs) for this commit.

Metadata

Metadata

Assignees

Labels

A-kv-distributionRelating to rebalancing and leasing.C-performancePerf of queries or internals. Solution not expected to change functional behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions