-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvfollowerreadsccl: excessive overhead in canSendToFollower #62447
Copy link
Copy link
Closed
Labels
A-kv-distributionRelating to rebalancing and leasing.Relating to rebalancing and leasing.C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.
Description
As seen in #62359, kvfollowerreadsccl.canSendToFollower started using a significant amount of resources in the week before Feb 19. The following flame graph shows that this was via DistSender.sendToReplicas, with the majority of the time spent in pgerror.Newf via checkEnterpriseEnabled.
The offending PR was #59571, kv95 benchmarks show a drop from 60712 ops/s to 55565 ops/s (median over 5 runs) for this commit.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-distributionRelating to rebalancing and leasing.Relating to rebalancing and leasing.C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.
