-
Notifications
You must be signed in to change notification settings - Fork 4.1k
log: the intercept mechanism prevents entries from being emitted to logging #61335
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-cc-enablementPertains to current CC production issues or short-term projectsPertains to current CC production issues or short-term projectsA-loggingIn and around the logging infrastructure.In and around the logging infrastructure.A-securityC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Description
When the user enables "logspy", i.e. injects a logging interceptor, the entries are passed to the interceptor and do not go to the log file any more.
This makes any log entry disappear entirely. Including all the audit logging which is required for security purpose.
We must change the logspy / intercept mechanism to have "tee" behavior and let the entries continue to go to log files or other sinks.
Found by @miretskiy
cc @aaron-crl @tbg
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-cc-enablementPertains to current CC production issues or short-term projectsPertains to current CC production issues or short-term projectsA-loggingIn and around the logging infrastructure.In and around the logging infrastructure.A-securityC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.