Skip to content

kvnemesis: replace string matching with error type checks in validator #61319

Closed
Closed
kvnemesis: replace string matching with error type checks in validator#61319
Labels
A-kvAnything in KV that doesn't belong in a more specific category.A-testingTesting tools and infrastructureC-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.T-kvKV TeamX-staleno-issue-activity
@nvb

Description

@nvb
nvb
opened on Mar 2, 2021

The kvnemesis validator's processOp method contains a mix of string matching (see resultIsErrorStr) and error type checking (e.g. kvserver.IsRetriableReplicationChangeError) code. We should push to switch more of these raw string checks into type checked error handling. This will force us to refine the KV interface and results in less fragile code.

Jira issue: CRDB-3039

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-kvAnything in KV that doesn't belong in a more specific category.A-testingTesting tools and infrastructureC-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.T-kvKV TeamX-staleno-issue-activity

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions