Skip to content

server: data race in VirtualizationWithContext #61091

Closed
#61100
Closed
server: data race in VirtualizationWithContext#61091
#61100
Assignees
andy-kimball
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
@RaduBerinde

Description

@RaduBerinde
RaduBerinde
opened on Feb 24, 2021

Test failure: https://teamcity.cockroachdb.com//viewLog.html?buildId=2714781&buildTypeId=Cockroach_MergedExtendedCi

Race from full_output.txt:

WARNING: DATA RACE
Write at 0x00000a27b408 by goroutine 603:
  github.com/shirou/gopsutil/internal/common.VirtualizationWithContext()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/shirou/gopsutil/internal/common/common_linux.go:243 +0x955
  github.com/shirou/gopsutil/host.VirtualizationWithContext()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/shirou/gopsutil/host/host_linux.go:365 +0x5a
  github.com/shirou/gopsutil/host.Virtualization()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/shirou/gopsutil/host/host.go:141 +0x97
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.populateHardwareInfo()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:350 +0x77
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*UpdateChecker).buildUpdatesURL()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/update_checker.go:194 +0x45a
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*UpdateChecker).CheckForUpdates()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/update_checker.go:106 +0x12f
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*UpdateChecker).maybeCheckForUpdates()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/update_checker.go:166 +0x111
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*UpdateChecker).PeriodicallyCheckForUpdates.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/update_checker.go:85 +0x350
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:351 +0x149

Previous write at 0x00000a27b408 by goroutine 230:
  github.com/shirou/gopsutil/internal/common.VirtualizationWithContext()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/shirou/gopsutil/internal/common/common_linux.go:243 +0x955
  github.com/shirou/gopsutil/host.VirtualizationWithContext()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/shirou/gopsutil/host/host_linux.go:365 +0x5a
  github.com/shirou/gopsutil/host.Virtualization()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/shirou/gopsutil/host/host.go:141 +0x97
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.populateHardwareInfo()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:350 +0x77
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*Reporter).populateEnvironment()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:248 +0x424
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*Reporter).CreateReport()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:173 +0x21a
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*Reporter).ReportDiagnostics()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:128 +0x128
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*Reporter).PeriodicallyReportDiagnostics.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:104 +0x552
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:351 +0x149

Goroutine 603 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:346 +0x107
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*UpdateChecker).PeriodicallyCheckForUpdates()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/update_checker.go:75 +0xf6
  github.com/cockroachdb/cockroach/pkg/server.(*Server).StartDiagnostics()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:2364 +0x99
  github.com/cockroachdb/cockroach/pkg/cli.(*transientCluster).start()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo_cluster.go:299 +0x1976
  github.com/cockroachdb/cockroach/pkg/server.(*Server).PreStart()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1666 +0x447e
  github.com/cockroachdb/cockroach/pkg/server.(*Server).Start()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1079 +0x50
  github.com/cockroachdb/cockroach/pkg/server.(*TestServer).Start()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/testserver.go:461 +0x8b5
  github.com/cockroachdb/cockroach/pkg/cli.(*transientCluster).start()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo_cluster.go:206 +0x8d0
  github.com/cockroachdb/cockroach/pkg/cli.runDemo()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo.go:279 +0x31c
  github.com/cockroachdb/cockroach/pkg/cli.init.4.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo.go:55 +0x44
  github.com/cockroachdb/cockroach/pkg/cli.MaybeDecorateGRPCError.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/error.go:194 +0x99
  github.com/spf13/cobra.(*Command).execute()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:826 +0x535
  github.com/spf13/cobra.(*Command).ExecuteC()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:914 +0x431
  github.com/spf13/cobra.(*Command).Execute()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:864 +0x364
  github.com/cockroachdb/cockroach/pkg/cli.Run()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli.go:296 +0x343
  github.com/cockroachdb/cockroach/pkg/cli.cliTest.RunWithArgs.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli_test.go:352 +0x380
  github.com/cockroachdb/cockroach/pkg/cli.cliTest.RunWithArgs()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli_test.go:353 +0xe4
  github.com/cockroachdb/cockroach/pkg/cli.Example_demo()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli_test.go:444 +0x127d
  testing.runExample()
      /usr/local/go/src/testing/run_example.go:62 +0x2b5
  testing.runExamples()
      /usr/local/go/src/testing/example.go:44 +0x228
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1346 +0x464
  github.com/cockroachdb/cockroach/pkg/cli_test.TestMain()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/main_test.go:34 +0xaf
  main.main()
      _testmain.go:219 +0x271

Goroutine 230 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:346 +0x107
  github.com/cockroachdb/cockroach/pkg/server/diagnostics.(*Reporter).PeriodicallyReportDiagnostics()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/diagnostics/reporter.go:93 +0xf6
  github.com/cockroachdb/cockroach/pkg/server.(*SQLServer).StartDiagnostics()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server_sql.go:898 +0x11a
  github.com/cockroachdb/cockroach/pkg/server.(*Server).StartDiagnostics()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:2365 +0x9a
  github.com/cockroachdb/cockroach/pkg/cli.(*transientCluster).start()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo_cluster.go:299 +0x1976
  github.com/cockroachdb/cockroach/pkg/server.(*Server).PreStart()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1666 +0x447e
  github.com/cockroachdb/cockroach/pkg/server.(*Server).Start()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/server.go:1079 +0x50
  github.com/cockroachdb/cockroach/pkg/server.(*TestServer).Start()
      /go/src/github.com/cockroachdb/cockroach/pkg/server/testserver.go:461 +0x8b5
  github.com/cockroachdb/cockroach/pkg/cli.(*transientCluster).start()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo_cluster.go:206 +0x8d0
  github.com/cockroachdb/cockroach/pkg/cli.runDemo()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo.go:279 +0x31c
  github.com/cockroachdb/cockroach/pkg/cli.init.4.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/demo.go:55 +0x44
  github.com/cockroachdb/cockroach/pkg/cli.MaybeDecorateGRPCError.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/error.go:194 +0x99
  github.com/spf13/cobra.(*Command).execute()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:826 +0x535
  github.com/spf13/cobra.(*Command).ExecuteC()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:914 +0x431
  github.com/spf13/cobra.(*Command).Execute()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:864 +0x364
  github.com/cockroachdb/cockroach/pkg/cli.Run()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli.go:296 +0x343
  github.com/cockroachdb/cockroach/pkg/cli.cliTest.RunWithArgs.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli_test.go:352 +0x380
  github.com/cockroachdb/cockroach/pkg/cli.cliTest.RunWithArgs()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli_test.go:353 +0xe4
  github.com/cockroachdb/cockroach/pkg/cli.Example_demo()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/cli_test.go:444 +0x127d
  testing.runExample()
      /usr/local/go/src/testing/run_example.go:62 +0x2b5
  testing.runExamples()
      /usr/local/go/src/testing/example.go:44 +0x228
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1346 +0x464
  github.com/cockroachdb/cockroach/pkg/cli_test.TestMain()
      /go/src/github.com/cockroachdb/cockroach/pkg/cli/main_test.go:34 +0xaf
  main.main()
      _testmain.go:219 +0x271
==================

Metadata

Metadata

Assignees

Labels

C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions