-
Notifications
You must be signed in to change notification settings - Fork 4.1k
tracing,sql: remove option to bypass the tracing registry #59315
Copy link
Copy link
Closed
Labels
A-tracingRelating to tracing in CockroachDB.Relating to tracing in CockroachDB.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Description
In #58902 we introduced a leak-detection for un-Finish()ed tracing.Spans. We did this by making sure that on server shutdown the tracing registry was empty (all newly started spans create an entry there, and remove themselves when finished). In doing so we observed that spans created within txnState.resetForNewSQLTxn aren't Finish()-ed during server shut down. We introduced a tracing.WithBypassRegistry() for that codepath, with the intention of addressing it pre-21.1. It'd be nice to figure out how we could ensure that the Spans are finished explicitly so that we're able to grab a hold of them in the registry (which will then let us introspect them).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-tracingRelating to tracing in CockroachDB.Relating to tracing in CockroachDB.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.