-
Notifications
You must be signed in to change notification settings - Fork 4.1k
typedesc: consider adding an error to typedesc.UserDefinedTypeOIDToID #58414
Copy link
Copy link
Closed
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Description
Describe the problem
We have code to convert an OID to a descpb.ID that assumes that the OID is larger than a constant. When it isn't we wrap around and end up producing and bogus descriptor ID. This is bug prone. We should return an error.
cockroach/pkg/sql/catalog/typedesc/type_desc.go
Lines 148 to 150 in 448663c
| // UserDefinedTypeOIDToID converts a user defined type OID into a | |
| // descriptor ID. | |
| func UserDefinedTypeOIDToID(oid oid.Oid) descpb.ID { |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)