-
Notifications
You must be signed in to change notification settings - Fork 4.1k
workload/schemachange: classify and handle errors in all operations #56119
Copy link
Copy link
Closed
Labels
A-testingTesting tools and infrastructureTesting tools and infrastructureC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Description
Right now errors occur very frequently inside the schemachange workload and there is no mechanism that checks to see if the error makes sense or not. For example, if we try to add a column to a table that does not exist, we should assert that we receive the right error code for an undefined table.
All ops should be updated up to the standard above:
- addColumn (workload/schemachange: improve errors; initial changes #55521)
- addConstraint (workload/schemachange: complete error screening #57491)
- createIndex (workload/schemachange: complete error screening #57491)
- createSequence (workload/schemachange: improve error screening #56379)
- createTable (workload/schemachange: improve errors; initial changes #55521)
- createTableAs (workload/schemachange: improve errors; initial changes #55521)
- createView (workload/schemachange: improve errors; initial changes #55521)
- createEnum (workload/schemachange: screen for errors in operations #56184)
- createSchema (workload/schemachange: screen for errors in operations #56184)
- dropColumn (workload/schemachange: screen for errors in operations #56184)
- dropColumnDefault (workload/schemachange: screen for errors in operations #56184)
- dropColumnNotNull (workload/schemachange: screen for errors in operations #56184)
- dropColumnStored (workload/schemachange: complete error screening #57491)
- dropConstraint (workload/schemachange: complete error screening #57491)
- dropIndex (workload/schemachange: complete error screening #57491)
- dropSequence (workload/schemachange: improve error screening #56379)
- dropTable (workload/schemachange: improve error screening #56379)
- dropView (workload/schemachange: improve error screening #56379)
- dropSchema (workload/schemachange: complete error screening #57491)
- renameColumn (workload/schemachange: screen for errors in operations #56184)
- renameIndex (workload/schemachange: complete error screening #57491)
- renameSequence (workload/schemachange: improve error screening #56379)
- renameTable (workload/schemachange: screen for errors in operations #56184)
- renameView (workload/schemachange: screen for errors in operations #56184)
- setColumnDefault (workload/schemachange: complete error screening #57491)
- setColumnNotNull (workload/schemachange: complete error screening #57491)
- setColumnType (workload/schemachange: complete error screening #57491)
- insertRow (workload/schemachange: improve error screening #56379)
Once all the ops are up to date:
- remove extra code (marked by TODOs) in 5b60540 (workload/schemachange: complete error screening #57491)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-testingTesting tools and infrastructureTesting tools and infrastructureC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)