-
Notifications
You must be signed in to change notification settings - Fork 4.1k
cli: productionize 'merge-logs' #49509
Copy link
Copy link
Open
Labels
A-cc-enablementPertains to current CC production issues or short-term projectsPertains to current CC production issues or short-term projectsA-cli-adminCLI commands that pertain to controlling and configuring nodesCLI commands that pertain to controlling and configuring nodesA-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-supportability
Description
The cockroach debug merge-logs sub-command is not really a "debug" command.
Moreover, with the advent of #48051 we want a general-purpose log editor, and the logic in merge-logs achieves this.
The code should be updated:
- make the "merge-logs" sub-command a non-debug thing, for example
cockroach log merge-files - rename the
--toargument to--until, since it's a time boundary - move the command-line flag initialization from
debug.gotoflags.go - enhance the flag description texts
- add new version parser log: implement a crdb-v2 log entry parser and use it in
debug merge-logs#65504 - add option to reverse order cli: support reverse order in
debug merge-logs#32956 - node ID prefix in output cli: debug merge-logs output should include node id to ensure uniqueness #55395
Jira issue: CRDB-6319
Epic CRDB-20791
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-cc-enablementPertains to current CC production issues or short-term projectsPertains to current CC production issues or short-term projectsA-cli-adminCLI commands that pertain to controlling and configuring nodesCLI commands that pertain to controlling and configuring nodesA-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-supportability