Skip to content

sql: investigate BenchmarkDelete100_Cockroach slowdown #4386

@petermattis

Description

@petermattis

#4384 added support for using CommitInBatch with delete requests which showed a very nice performance improvement for the Delete{1,10} benchmarks. But it resulted in a reproducible slowdown for the Delete100 benchmark. The code in question is in `sql/delete.go:

        pErr = p.txn.CommitInBatch(b)

The slowdown can removed by replacing this with: (this was what the code was doing before #4384).

        pErr = p.txn.Run(b)
        if pErr == nil {
            pErr = p.txn.Commit()
        }

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)C-performancePerf of queries or internals. Solution not expected to change functional behavior.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions