Skip to content

kv,roachpb: simplify LeafTxnFinalState  #43192

@knz

Description

@knz

Requested by @andreimatei in #43032 (review)

Currently LeafTxnInputState and LeafTxnFinalState have an entire copy of the Transaction record. This is necessary: the structs should only contain the fields from the txn that can actually be updated by the leaf.

Andrei:

I think they are simply:
none from TxnMeta
Status
ObservedTimestamps

We can have the txn field too for backwards compatibility, but stop setting it based on a cluster version.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-kv-transactionsRelating to MVCC and the transactional model.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.X-staleno-issue-activity

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions