-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kv,roachpb: simplify LeafTxnFinalState #43192
Copy link
Copy link
Closed
Labels
A-kv-transactionsRelating to MVCC and the transactional model.Relating to MVCC and the transactional model.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.X-staleno-issue-activity
Description
Requested by @andreimatei in #43032 (review)
Currently LeafTxnInputState and LeafTxnFinalState have an entire copy of the Transaction record. This is necessary: the structs should only contain the fields from the txn that can actually be updated by the leaf.
Andrei:
I think they are simply:
none from TxnMeta
Status
ObservedTimestamps
We can have the txn field too for backwards compatibility, but stop setting it based on a cluster version.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-transactionsRelating to MVCC and the transactional model.Relating to MVCC and the transactional model.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.X-staleno-issue-activity