Skip to content

cli/dump: COMMENT ON missing #42875

@namibj

Description

@namibj

Describe the problem

Please describe the issue you observed, and any steps we can take to reproduce it:
If a column has a comment (via COMMENT ON), the comment will be missing in the cockroach dumo --dump-mode schema output.

To Reproduce

What did you do? Describe in your own words.

If possible, provide steps to reproduce the behavior:

  1. Create a schema with a comment (the example in the docs will do)
  2. Issue cockroach dump --dump-mode schema <database> | grep COMMENT
  3. Observe the lack of output, which implies no comment was dumped with the schema.

Expected behavior
The schema is dumped with all comments.

Environment:

  • CockroachDB version v19.2.0
  • Server OS: Linux/archlinux
  • Client app cockroach dump

Additional context
What was the impact?

It silently swallowed my comments, which specified preliminary enum mappings for int2 columns. Thankfully it wasn't much.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-sql-vtablesVirtual tables - pg_catalog, information_schema etcC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)S-3-ux-surpriseIssue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions