-
Notifications
You must be signed in to change notification settings - Fork 4.1k
cli/dump: COMMENT ON missing #42875
Copy link
Copy link
Closed
Labels
A-sql-vtablesVirtual tables - pg_catalog, information_schema etcVirtual tables - pg_catalog, information_schema etcC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)S-3-ux-surpriseIssue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Description
Describe the problem
Please describe the issue you observed, and any steps we can take to reproduce it:
If a column has a comment (via COMMENT ON), the comment will be missing in the cockroach dumo --dump-mode schema output.
To Reproduce
What did you do? Describe in your own words.
If possible, provide steps to reproduce the behavior:
- Create a schema with a comment (the example in the docs will do)
- Issue
cockroach dump --dump-mode schema <database>| grep COMMENT - Observe the lack of output, which implies no comment was dumped with the schema.
Expected behavior
The schema is dumped with all comments.
Environment:
- CockroachDB version v19.2.0
- Server OS: Linux/archlinux
- Client app cockroach dump
Additional context
What was the impact?
It silently swallowed my comments, which specified preliminary enum mappings for int2 columns. Thankfully it wasn't much.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-sql-vtablesVirtual tables - pg_catalog, information_schema etcVirtual tables - pg_catalog, information_schema etcC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)S-3-ux-surpriseIssue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.