-
Notifications
You must be signed in to change notification settings - Fork 4.1k
storage/engine: TestMVCCPutNewEpochLowerSequence does not do what it says #42310
Copy link
Copy link
Closed
Labels
A-storageRelating to our storage engine (Pebble) on-disk storage.Relating to our storage engine (Pebble) on-disk storage.A-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Description
Found while investigating #42250.
The comment on this test says:
// Test that a write with a higher epoch is permitted even when the sequence
// number has decreased compared to an existing intent. This is because, on
// transaction restart, the sequence number should not be compared with intents
// from the old epoch.
// Additionally the intent history is blown away when a transaction restarts.
The problem with the last sentence is that the test ever only issues a single MVCCPut, so it does not generate an intent history to start with. Therefore, the check that the intent history disappears upon restart does not actually test anything.
Reactions are currently unavailable
Metadata
Metadata
Labels
A-storageRelating to our storage engine (Pebble) on-disk storage.Relating to our storage engine (Pebble) on-disk storage.A-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.