-
Notifications
You must be signed in to change notification settings - Fork 4.1k
util/log: TestCrashReportingPacket fails on go1.12 #35792
Copy link
Copy link
Closed
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Description
The expected line numbers are off by one:
--- FAIL: TestCrashReportingPacket (0.20s)
--- FAIL: TestCrashReportingPacket/#00 (0.00s)
crash_reporting_packet_test.go:154: expected crash_reporting_packet_test.go:83: boom, got crash_reporting_packet_test.go:84: boom
--- FAIL: TestCrashReportingPacket/#01 (0.00s)
crash_reporting_packet_test.go:154: expected crash_reporting_packet_test.go:91: baam, got crash_reporting_packet_test.go:92: baam
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-loggingIn and around the logging infrastructure.In and around the logging infrastructure.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.