Skip to content

storage: RelocateRange doesn't handle edge cases properly #29130

Closed
Closed
storage: RelocateRange doesn't handle edge cases properly#29130
Assignees
a-robinson
Labels
A-kv-distributionRelating to rebalancing and leasing.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
2.1
@benesch

Description

@benesch
benesch
opened on Aug 27, 2018

cockroach/pkg/storage/merge_queue.go

Lines 267 to 272 in 3c6c71d

// TODO(benesch): RelocateRange needs to be made more robust. It cannot
// currently handle certain edge cases, like multiple stores on one node. It
// also adds all new replicas before removing any old replicas, rather than
// performing interleaved adds/removes, resulting in a moment where the
// number of replicas is potentially double the configured replication
// factor.

cockroach/pkg/storage/replica_command.go

Lines 956 to 957 in 2f2467c

// This is best-effort; if replication queues are enabled and a change in
// membership happens at the same time, there will be errors.

Metadata

Metadata

Assignees

Labels

A-kv-distributionRelating to rebalancing and leasing.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions