-
Notifications
You must be signed in to change notification settings - Fork 4.1k
metrics: txn duration metric is broken #28424
Copy link
Copy link
Closed
Labels
A-kv-clientRelating to the KV client and the KV interface.Relating to the KV client and the KV interface.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.S-3-wrong-metadataIssues causing erroneous metadata or monitoring stats to be returned.Issues causing erroneous metadata or monitoring stats to be returned.
Milestone
Description
I noticed this while doing some performance profiling - a histogram was causing a ton of Sprintfs via Error.Errorf. I dug in and found out that the Durations histogram that's part of TxnMetrics always gets updated with a preposterously large number, which gets capped at 10 seconds. I'm not sure why this happens, probably the txnStartNanos is set to 0 or something.
Here's a screenshot of the UI which agrees with my finding:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-clientRelating to the KV client and the KV interface.Relating to the KV client and the KV interface.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.S-3-wrong-metadataIssues causing erroneous metadata or monitoring stats to be returned.Issues causing erroneous metadata or monitoring stats to be returned.
