Skip to content

sql/types: structs implement types.T by value, should by by pointer #26680

Closed
Closed
sql/types: structs implement types.T by value, should by by pointer#26680
Labels
A-sql-typingSQLtype inference, typing rules, type compatibility.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.C-performancePerf of queries or internals. Solution not expected to change functional behavior.
@knz

Description

@knz
knz
opened on Jun 13, 2018

This is a similar problem as we had in package tree back in the days: the various non-empty structs implement the interface by value. This has poor allocation behavior.

found by @RaduBerinde

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-sql-typingSQLtype inference, typing rules, type compatibility.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.C-performancePerf of queries or internals. Solution not expected to change functional behavior.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions