-
Notifications
You must be signed in to change notification settings - Fork 4.1k
storage: improve EndTransaction's AbortSpan declaration #24285
Copy link
Copy link
Closed
Labels
C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.
Milestone
Description
See #24194 (comment) via @bdarnell:
EndTransaction currently declares the abort span for read/write whether it's a commit or abort:
cockroach/pkg/storage/replica_command.go
Line 165 in f111ff4
| spans.Add(spanset.SpanReadWrite, roachpb.Span{Key: keys.AbortSpanKey(header.RangeID, header.Txn.ID)}) |
Although I think you're right that it doesn't actually need to unless it's an abort and we're resolving local intents.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.