Skip to content

storage: improve EndTransaction's AbortSpan declaration #24285

@tbg

Description

@tbg

See #24194 (comment) via @bdarnell:

EndTransaction currently declares the abort span for read/write whether it's a commit or abort:

spans.Add(spanset.SpanReadWrite, roachpb.Span{Key: keys.AbortSpanKey(header.RangeID, header.Txn.ID)})

Although I think you're right that it doesn't actually need to unless it's an abort and we're resolving local intents.

Metadata

Metadata

Assignees

Labels

C-performancePerf of queries or internals. Solution not expected to change functional behavior.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions